Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WD-19698] Custom ISO can_delete permission check. #1129

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Kxiru
Copy link
Contributor

@Kxiru Kxiru commented Feb 26, 2025

Done

  • Custom ISO - can delete permission implemented.
  • Codebase refactor - Inkeeping with the fact that the there is a disassociation between Storage pools and volumes within the codebase in Context.
    • Split /api/storage-pools into /api/storage-pools and /api/storage-volumes and updated all imports.
    • Consequently, storageVolumes now have their own entitlements file and api file.

Fixes [list issues/bugs if needed]

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Attempt to delete a Custom ISO volume with a user that has the pemissions to do so.
    • Attempt to delete a Custom ISO volume with a user that does not have the pemissions to do so.
    • Observe the expected behaviour.

Screenshots

Custom ISOs, one of which the user has permissions to delete, the other, they do not.
image

@Kxiru Kxiru requested a review from edlerd February 26, 2025 20:28
@Kxiru Kxiru self-assigned this Feb 26, 2025
@webteam-app
Copy link

@Kxiru Kxiru changed the title feat: [WD-19698] Custom ISO permission check. feat: [WD-19698] Custom ISO can_delete permission check. Feb 26, 2025
@Kxiru Kxiru force-pushed the storage-volumes-permission-checks branch from 4852ffd to 914a058 Compare February 26, 2025 21:16
@Kxiru Kxiru requested a review from edlerd February 26, 2025 21:16
@Kxiru Kxiru force-pushed the storage-volumes-permission-checks branch 3 times, most recently from 30e38d6 to 4fbf6ba Compare February 27, 2025 09:15
@Kxiru Kxiru requested a review from edlerd February 27, 2025 09:15
@Kxiru Kxiru force-pushed the storage-volumes-permission-checks branch from 4fbf6ba to e289127 Compare February 27, 2025 09:44
- Custom ISO - can delete
- Codebase refactor.

Signed-off-by: Nkeiruka <[email protected]>
@Kxiru Kxiru force-pushed the storage-volumes-permission-checks branch from e289127 to a4bd9fc Compare February 27, 2025 14:11
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and Code LGTM, good work 👍

@Kxiru Kxiru merged commit 17321ef into canonical:main Feb 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants