Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant void calls #1128

Merged
merged 8 commits into from
Feb 27, 2025
Merged

Remove redundant void calls #1128

merged 8 commits into from
Feb 27, 2025

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 26, 2025

Done

solved two issues surfaced by the TICS check:

  • remove redundant void calls
  • fix copy paste error in permissions

@webteam-app
Copy link

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being so meticulous in addressing the void function issue(s). What would be the best way to test the copy/paste permissions fix?

@edlerd
Copy link
Collaborator Author

edlerd commented Feb 26, 2025

Thanks for being so meticulous in addressing the void function issue(s). What would be the best way to test the copy/paste permissions fix?

the copy paste error was this one: b76a48b#diff-bc94b30448b316e2f795f37eb93fd41b9a33670e82160c55fdc713a85f3a6021R101

I added more ESLint rules (the ones that TICS is checking for and have an automated fix) to this one after creating the PR, you can see the new rules as individual commits.

Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for these low-level improvements!

@edlerd edlerd merged commit 83f1786 into canonical:main Feb 27, 2025
11 checks passed
@edlerd edlerd deleted the fix-code-style branch February 27, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants