-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant void calls #1128
Conversation
…missions Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
Signed-off-by: David Edler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being so meticulous in addressing the void function issue(s). What would be the best way to test the copy/paste permissions fix?
the copy paste error was this one: b76a48b#diff-bc94b30448b316e2f795f37eb93fd41b9a33670e82160c55fdc713a85f3a6021R101 I added more ESLint rules (the ones that TICS is checking for and have an automated fix) to this one after creating the PR, you can see the new rules as individual commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for these low-level improvements!
Done
solved two issues surfaced by the TICS check: