Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow member specific server setting for core.syslog_server WD-18265 #1127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 25, 2025

Done

  • Allow member specific server setting for core.syslog_server in clustered environment
  • Adjust edit button for clustered server settings to be visually more like the non-clustered settings
  • Adjust spacing for clustered server settings
  • Fix race on loading network edit for cluster specific edit of physical managed networks parent field.

Fixes WD-18265

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • explore server settings in clustered and non-clustered backends.
    • ensure the core.syslog_server setting is handled correctly for member specific, and generic values in cluster backends

@webteam-app
Copy link

@edlerd edlerd force-pushed the member-specific-server-setting-syslog branch from 78040ed to bcd6dda Compare February 25, 2025 21:47
Kxiru
Kxiru previously approved these changes Feb 28, 2025
Copy link
Contributor

@Kxiru Kxiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a functional and visual perspective! Thanks so much for this David. Just a merge conflict to address and then we're good to go!

Screenshots for visibility:
image

image

image

@edlerd edlerd force-pushed the member-specific-server-setting-syslog branch from bcd6dda to 82f2c18 Compare February 28, 2025 15:09
…erver in clustered environment WD-18265

Signed-off-by: David Edler <[email protected]>
@edlerd edlerd force-pushed the member-specific-server-setting-syslog branch from 82f2c18 to 4b9e1da Compare February 28, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants