Show upload error in modal, not in toast

[edlerd]

Done

• Show upload error in modal, not in toast, as that will not be visible with an open modal

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, build and run as described in the docs.
2. Perform the following QA steps:
   • upload a custom iso
   • upload the same file again, the error should displayed inside the modal, not as toast that is behind the modal.

[webteam-app]

Demo

Jenkins

demos.haus

[mas-who]

Small QA nit, happy to merge as is:

I think it's a little weird to have the error notification showing inside the modal as well as the custom isos list page. The upload error seems to be scoped to the modal.

Maybe we can check in CustomIsoList if the upload modal is open and conditionally render NotificationRow?

[edlerd]

I think it's a little weird to have the error notification showing inside the modal as well as the custom isos list page. The upload error seems to be scoped to the modal.

Right, seems better to have a custom error inside the modal, than to rely on the notify hook for that reason. Change the PR slightly to adjust to it.

[mas-who]

LGTM, thanks for the adjustment