Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generalise bulk delete button across UI pages [WD-19546] #1123

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat: generalise bulk delete button across UI pages [WD-19546] #1123

merged 1 commit into from
Feb 25, 2025

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 24, 2025

Done

  • Create a generalised bulk delete button component to standardise usage across UI pages

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Test Bulk delete instances, images, instance and volume snapshots

@webteam-app
Copy link

Demo

Jenkins

demos.haus

edlerd
edlerd reviewed Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, some comments below to improve the generic component.

@mas-who mas-who force-pushed the generalise-bulk-delete branch 3 times, most recently from 8068fa5 to 304730e Compare February 25, 2025 07:41
edlerd
edlerd reviewed Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA seems mostly all right, just the breakdowns can be tweaked a bit and some minor code quality suggestions below.

@mas-who mas-who force-pushed the generalise-bulk-delete branch 2 times, most recently from 74be101 to 6ea7119 Compare February 25, 2025 09:33
@mas-who mas-who force-pushed the generalise-bulk-delete branch from 6ea7119 to 3825c39 Compare February 25, 2025 10:19
edlerd
edlerd approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA and code LGTM 👍

@mas-who mas-who merged commit 3fd8cb2 into canonical:main Feb 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mas-who @webteam-app @edlerd @MasWho