Add Sunbeam support to OpenStack plugin #996
Merged
+148
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pponnuvel
approved these changes
Jan 8, 2025
| core24 20240920 609 latest/stable canonical** base | ||
| juju 3.5.5 29058 3.5/stable canonical** - | ||
| lxd 5.0.4-497fe1e 31333 5.0/stable/… canonical** - | ||
| microceph 18.2.4+snapa97ae91192 1234 reef/edge canonical** held |
There was a problem hiding this comment.
Do we need a followup issue to track these "edges" and convert them to stable at some point?
There was a problem hiding this comment.
sunbeam 2024.1 is not released yet and so has no 2024/1/stable channel. I think adding a scenario to detect usage of the edge snap makes sense but we need wait until a stable snap is available.
hillpd
approved these changes
Jan 8, 2025
Also: * fixes Juju units summary to include charm revision where charm has no repo-info file. * adds snap channel to summary output * shows pods and containers from microk8s Resolves: canonical#995
|
I'll go ahead and merge. We can always add more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Resolves: #995