-
Notifications
You must be signed in to change notification settings - Fork 10
[docs] Updates starter pack & enables GA #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mvlassis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried locally on my machine and everything renders as expected. I found some nitpicks, but will create changes in the starter pack repo so that they are propagated.
Also note that the cookie banner is rendered in the exact middle of the screen, I'm not sure if that is expected or that should be in a different place (e.g. bottom).
The placement attempts to replicate the same placement on ubuntu.com and canonical.com. And as per my comment in the ml-flow PR, |
|
Thanks @SecondSkoll for the input! Removing that workflow then. |
This PR:
It is part of this Jira ticket: https://warthogs.atlassian.net/browse/KF-7607
You can test the PR by checking the Docs build in the CI below (docs/readthedocs entry) or run it locally by making
make clean&make run. You should see the added cookies banner + the new starter pack format.