fix: store dss logs in snap common folder #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
reviewed
Apr 4, 2025
Contributor
orfeas-k
left a comment
orfeas-k
left a comment
There was a problem hiding this comment.
Small comments, mostly LGTM. Tested and the issue seems to have been fixed!
orfeas-k
approved these changes
Apr 4, 2025
misohu
added a commit
that referenced
this pull request
Apr 7, 2025
* Fix MLflow deployment for Canonical k8s (#195) * Fix MLflow deployment for Canonical k8s * Fix init container name * Fix shared folder on Canonical k8s (#196) * feat: run integration tests on canonical k8s (#203) * feat: run integration tests on canonical k8s * fix: gpu tests to run on Canonical k8s (#204) * fix: run gpu ci on caonical k8s * feat: update docs for canonical k8s (#215) * feat: update docs for canonical k8s * Angel's review --------- Co-authored-by: afgambin <angel.fernandez@canonical.com> * fix: use security context for the mounted volumens (#214) * fix: store dss logs in snap common folder (#218) * fix: store logs in snap common folder --------- Co-authored-by: deusebio <edeusebio85@gmail.com> --------- Co-authored-by: afgambin <angel.fernandez@canonical.com> Co-authored-by: deusebio <edeusebio85@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #213
Stores the logs in the
/var/snap/data-science-stack/common/logsfolderTo test this
sudo snap remove data-science-stacksnapcraftsudo snap install data-science-stack_0.1-<hash>_amd64.snap --dangerousdata-science-stack.dss status(it should complain about config)/var/snap/data-science-stack/common/logs/dss.log