-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add playwright tests on content system #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e74b85
to
e87ec9b
Compare
a9140d3
to
8347727
Compare
0b8111d
to
079d9a0
Compare
3df10a5
to
0c5ae69
Compare
0c5ae69
to
4dc6f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Tests have been passing on github workflow, I am still facing issues with getting them running locally, but I guess we can go ahead with this as an initial step.
That said, the .env file has to be sourced separately now, which was not case previously for dotrun.
Thanks for the great work and patience on this task. 😃
env: | ||
DISABLE_SSO: True | ||
SECRET_KEY: secret_key | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious, what token did we use here, I am guessing it's not a personal GH token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@immortalcodes Good question! The github action runner automatically adds a secret named GITHUB_TOKEN
that is accessible in workflow using secrets.GITHUB_TOKEN
. Therefore, we don't need to pass our own personal GH token when cloning repos.
Thanks for testing and approving @immortalcodes. We can connect to figure out the issues you're facing in your local environment. |
Done
QA
QA steps
Please note
Make sure to remove/disregard/reject Jira tasks created as a result of running tests. In the near-future, we will automate this cleaning up process after testsThe jira tasks are now automatically cleaned up (rejected and parent unlinked) after the tests so you don't have to do that manuallly.
Fixes