Skip to content

feat: Add playwright tests on content system #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Apr 8, 2025
Merged

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Mar 26, 2025

Done

  • test auth flow
  • test projects are loaded and visible
  • test page removal flow
  • test page change request flow
  • test page creation and submission flow
  • clean up jira tasks after tests
  • add workflow for playwright testing

QA

QA steps

  • Create a new branch from this branch and raise a PR to merge your branch to this branch
  • This will trigger the playwright actions on your PR
  • Verify all the actions are successful.

Please note
Make sure to remove/disregard/reject Jira tasks created as a result of running tests. In the near-future, we will automate this cleaning up process after tests
The jira tasks are now automatically cleaned up (rejected and parent unlinked) after the tests so you don't have to do that manuallly.

Fixes

@webteam-app
Copy link

@muhammad-ali-pk muhammad-ali-pk force-pushed the playwright-tests branch 2 times, most recently from a9140d3 to 8347727 Compare April 4, 2025 15:35
Copy link
Member

@immortalcodes immortalcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Tests have been passing on github workflow, I am still facing issues with getting them running locally, but I guess we can go ahead with this as an initial step.
That said, the .env file has to be sourced separately now, which was not case previously for dotrun.
Thanks for the great work and patience on this task. 😃

env:
DISABLE_SSO: True
SECRET_KEY: secret_key
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious, what token did we use here, I am guessing it's not a personal GH token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@immortalcodes Good question! The github action runner automatically adds a secret named GITHUB_TOKEN that is accessible in workflow using secrets.GITHUB_TOKEN. Therefore, we don't need to pass our own personal GH token when cloning repos.

@muhammad-ali-pk
Copy link
Contributor Author

Thanks for testing and approving @immortalcodes. We can connect to figure out the issues you're facing in your local environment.

@muhammad-ali-pk muhammad-ali-pk merged commit 8beccd0 into main Apr 8, 2025
7 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the playwright-tests branch April 8, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants