Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint failure #5320

Merged
merged 2 commits into from
May 28, 2024
Merged

chore: fix lint failure #5320

merged 2 commits into from
May 28, 2024

Conversation

TheRealFalcon
Copy link
Member

@TheRealFalcon TheRealFalcon commented May 23, 2024 •
edited
Loading

Proposed Commit Message

chore: fix lint failure

This file isn't included in the CI linting

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb
Copy link
Member

holmanb commented May 24, 2024

Can we add this file to CI as well?

@TheRealFalcon
chore: fix lint failure
bb10140 
Not sure why this didn't show up in PR.
@TheRealFalcon
Ruff the world
c672016
@holmanb holmanb self-requested a review May 27, 2024 22:45
@holmanb holmanb self-assigned this May 27, 2024
holmanb
holmanb approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheRealFalcon TheRealFalcon merged commit 01367a7 into canonical:main May 28, 2024
27 of 29 checks passed
@TheRealFalcon TheRealFalcon deleted the fix-lint branch May 28, 2024 22:05
holmanb pushed a commit that referenced this pull request Jun 28, 2024
@TheRealFalcon @holmanb
chore: fix lint failure (#5320)
d74aa10 
Also run ruff on all files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

Assignees

@holmanb holmanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheRealFalcon @holmanb