-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nvme support #5263
Add nvme support #5263
Conversation
a1aa342
to
4f77b7f
Compare
I'm still not entirely sure I understand the problem. I created a Noble VM on QEMU using the same version as the bug and used the reproducer as my cloud-config (plus adding my ssh key).
Logs:
If run again we get:
Am I missing something? My reproducer (a bit verbose because I copied the base pieces from pycloudlib):
|
The 1st log message in his bug report only appears when "fs_setup" is also specified in user-data:
https://github.com/canonical/cloud-init/blob/main/cloudinit/config/cc_disk_setup.py#L145-L155 |
@TheRealFalcon requesting re-review, the reporter updated the bug with more details about the reproducer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
14f2d01
to
678c95d
Compare
678c95d
to
958d292
Compare
Force pushed to update commit messages and squash one commit |
958d292
to
6b54ee5
Compare
Context
Fixes #5246
Also downgrade a warning log