-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disk_setup (and probably fs_setup) does not work with nvme drives #5246
Comments
NVME devices in Linux are not the only storage devices that have this differing form of naming for partitions, other examples would be SD cards (i.e. /dev/mmcblk0p1), partitioned loop devices (i.e. /dev/loop0p1) and I think software RAID devices (i.e. /dev/md0p1). |
@nilo85 thanks for filing this issue! It looks like cloud-init needs to update this code to support various different disk types. |
@nilo85 hey it looks like the config you shared can't invoke the codepath that caused the issue. Can you please provide the full config? I'm guessing that you tried to share just the relevant part and didn't realize that the error came from the fs format failure path. |
confirmed: #5263 (comment) |
This was my config, then I later removed the alias to "ssd" to remove alias being the issue
Pretty sure it is disk setup based on this line in the stacktrace?
I tried modifying the python code and added debug output etc but quickly realised why I dont code in python (couldnt make sens of it) ;) But it seems those enumerate methods are shared cross fs and disk setup I can try to give it a new try the next days to see if I can get better understanding exactly where we are in the flow. EDIT: you are probably right, it did create the partition table for me etc, but not any filesystems, so maybe I was just assuming it was disk_setup that was the issue due to the filename. I thought it was some disk verification step after creating layout that failed |
Bug report
When trying to partition a nvme ssd, it seems the cloud init assumes bad name convention for partitions.
It outputs
Where the real name convention is /dev/nvme0n1p1
Steps to reproduce the problem
Environment details
/usr/bin/cloud-init 24.1.3-0ubuntu3
https://github.com/Joshua-Riek/ubuntu-rockchip
cloud-init logs
The text was updated successfully, but these errors were encountered: