Avoid rendering messages with duplicate IDs #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,7 +89,7 @@ Candy.View.Template = (function(self){ | |||
|
|
|||
| self.Message = { | |||
| pane: '<div class="message-pane-wrapper"><ul class="message-pane"></ul></div>', | |||
| item: '<li><small data-timestamp="{{timestamp}}">{{time}}</small><div>' + | |||
| item: '<li data-message-id="{{id}}"><small data-timestamp="{{timestamp}}">{{time}}</small><div>' + | |||
There was a problem hiding this comment.
why not just id? might be used for other cases
There was a problem hiding this comment.
Just to avoid potential colision with any reserved name. Happy to change it if you're confident that data-id is ok. I'm not a front-end guy ;)
There was a problem hiding this comment.
I meant just id, not data-id :D but then you'd probably need a message- prefix to avoid collisions..
This is motivated by a race condition when loading archived messages (calling Candy.View.Pane.Message.show) at the same time as rendering an incoming message, such as when a 1-on-1 message arrives and auto-opens a new pane for the chat partner.
bklang
force-pushed
the
feature/avoid-duplicate-message-ids
branch
from
9c0fec9
to
6a096d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by a race condition when loading archived messages (calling Candy.View.Pane.Message.show) at the same time as rendering an incoming message, such as when a 1-on-1 message arrives and auto-opens a new pane for the chat partner.