Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Safari 12 (and other old browsers) #168

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

canadianveggie
Copy link
Owner

Need to polyfill queueMicrotask which isn't available in old versions of Firefox or Safari.

https://caniuse.com/?search=queueMicrotask

Will test in BrowserStack to ensure there aren't other problems.

hattip https://medium.com/display-nice/make-alpine-3-support-legacy-browsers-b4cced62f4f1

Need to polyfill queueMicrotask which isn't available in old versions of Firefox or Safari.

https://caniuse.com/?search=queueMicrotask
@canadianveggie canadianveggie merged commit a682e0c into main Sep 27, 2024
2 checks passed
@canadianveggie canadianveggie deleted the old_browser_support branch September 27, 2024 17:35
@canadianveggie
Copy link
Owner Author

Success!!!
Screenshot 2024-09-27 at 10 49 01 AM

@canadianveggie
Copy link
Owner Author

This worked great. Here's a chart of errors encountered by users who weren't able to start a game vs those that were.

Screenshot 2024-11-07 at 9 08 57 AM

Since this feature went live on September 27, there's been a big drop in users that only see errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant