refactor: apply auth profile only if other auth profiles are not enabled #19645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/zeebe
| @@ -34,7 +35,7 @@ public class WebappsConfigurationInitializer | |||
| private static final Set<String> WEBAPPS_PROFILES = | |||
| Set.of(OPERATE.getId(), TASKLIST.getId(), IDENTITY.getId()); | |||
| private static final Set<String> LOGIN_DELEGATED_PROFILES = | |||
| Set.of(IDENTITY_AUTH.getId(), SSO_AUTH.getId()); | |||
| Set.of(IDENTITY_AUTH.getId(), SSO_AUTH.getId(), AUTH_BASIC.getId()); | |||
There was a problem hiding this comment.
@Ben-Sheppard I am trying to understand the difference between AUTH , AUTH_BASIC and IDENTITY_AUTH
is AUTH_BASIC considered as authentication handled by (delegated to) identity with some basic functionalities?
How Identity webapp behaves when AUTH profile is used?
There was a problem hiding this comment.
Ah good point, so in this case its I guess not delegated in that sense to Identity, the AUTH_BASIC profile relies currently on the Spring basic authentication login (the browser popup) so actually in that sense I don't think its considered delegated i.e. to the Identity service.
I will remove it from this set
houssain-barouni
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would like to start making progress on integrating the webapps (starting with Operate) into the new central auth layer. This PR is a small refactor to the logic around when the default auth profile is applied.
Essentially I wanted to centralise that logic and remove the dependency on the Operate specific classes.