feat: add list, create, edit, delete roles to Identity UI #19637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component/identity
dlavrenuek
requested changes
Jun 21, 2024
Comment on lines
1
to
7
| /* | ||
| * @license Identity | ||
| * Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH under one or more contributor license | ||
| * agreements. Licensed under a proprietary license. See the License.txt file for more information. You may not use this | ||
| * file except in compliance with the proprietary license. | ||
| */ | ||
|
|
There was a problem hiding this comment.
The license header is from old Identity. We can delete if for now or include the new license header.
Comment on lines
19
to
50
| entity: role, | ||
| open, | ||
| onClose, | ||
| onSuccess, | ||
| }) => { | ||
| const { t } = useTranslate(); | ||
| const { enqueueNotification } = useNotifications(); | ||
|
|
||
| const [callDeleteApi, { loading }] = useApiCall(deleteRole); | ||
|
|
||
| const handleSubmit = async () => { | ||
| if (role) { | ||
| const { success } = await callDeleteApi({ | ||
| id: role.id, | ||
| }); | ||
|
|
||
| if (success) { | ||
| enqueueNotification({ | ||
| kind: "success", | ||
| title: t("Role has been deleted."), | ||
| }); | ||
| onSuccess(); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <Modal | ||
| open={open} | ||
| headline={t('Are you sure you want to delete the role "{{ name }}"?', { | ||
| name: role?.name, | ||
| })} |
There was a problem hiding this comment.
Descructuring role to { id, name } can make the code look a bit better
Suggested change
| entity: role, | |
| open, | |
| onClose, | |
| onSuccess, | |
| }) => { | |
| const { t } = useTranslate(); | |
| const { enqueueNotification } = useNotifications(); | |
| const [callDeleteApi, { loading }] = useApiCall(deleteRole); | |
| const handleSubmit = async () => { | |
| if (role) { | |
| const { success } = await callDeleteApi({ | |
| id: role.id, | |
| }); | |
| if (success) { | |
| enqueueNotification({ | |
| kind: "success", | |
| title: t("Role has been deleted."), | |
| }); | |
| onSuccess(); | |
| } | |
| } | |
| }; | |
| return ( | |
| <Modal | |
| open={open} | |
| headline={t('Are you sure you want to delete the role "{{ name }}"?', { | |
| name: role?.name, | |
| })} | |
| entity: { id, name }, | |
| open, | |
| onClose, | |
| onSuccess, | |
| }) => { | |
| const { t } = useTranslate(); | |
| const { enqueueNotification } = useNotifications(); | |
| const [callDeleteApi, { loading }] = useApiCall(deleteRole); | |
| const handleSubmit = async () => { | |
| if (role) { | |
| const { success } = await callDeleteApi({ id }); | |
| if (success) { | |
| enqueueNotification({ | |
| kind: "success", | |
| title: t("Role has been deleted."), | |
| }); | |
| onSuccess(); | |
| } | |
| } | |
| }; | |
| return ( | |
| <Modal | |
| open={open} | |
| headline={t('Are you sure you want to delete the role "{{ name }}"?', { | |
| name, | |
| })} |
| import usePermissions from "src/pages/roles/modals/usePermissions"; | ||
|
|
||
| const EditModal: FC<UseEntityModalProps<Role>> = ({ | ||
| entity: role, |
There was a problem hiding this comment.
FYI: I did not use desctucturing here because the variables name, description and permissions already exist, so you would need to name it like currentName etc... which in the end is longer than using role.name.
dlavrenuek
approved these changes
Jun 24, 2024
| id: role.id, | ||
| }); | ||
| const { success } = await callDeleteApi({ | ||
| id: id, |
There was a problem hiding this comment.
Suggested change
| id: id, | |
| id, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Identity UI support list/create/edit/delete on Role.
Related issues
Part of identity issue (#2818)