chore(optimize8): adjust parent POM relative path #19584
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misiekhardcore
approved these changes
Jun 20, 2024
|
I approved it but I don't know if it is correct. If it builds fine then it's fine by me |
|
@buccarel I think this might require updating all the other pom files in all sub-dirs as well. WDYT? |
misiekhardcore
requested review from
PHWaechtler
and removed request for
PHWaechtler
This reverts commit 44647ad.
buccarel
force-pushed
the
merge-optimize-in--adjust-parent
branch
from
64b95c7
to
038808a
Compare
|
@buccarel you assigned me as a reviewer but I have no java knowledge so I cannot properly review this. Can you choose someone from our BE engineers instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
DO NOT REVIEW
DO NOT MERGE