deps: Update spring boot to v3.3.1 (main) #19581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
![renovate-approve[bot]](https://avatars.githubusercontent.com/in/7394?s=60&v=4){kind=small}
github-actions
bot
added
component/zeebe
renovate
bot
force-pushed
the
renovate/main-spring-boot
branch
21 times, most recently
from
48a29d5
to
d436610
Compare
renovate
bot
force-pushed
the
renovate/main-spring-boot
branch
20 times, most recently
from
024c676
to
7b95647
Compare
renovate
bot
force-pushed
the
renovate/main-spring-boot
branch
from
7b95647
to
5b6ddfc
Compare
|
Strange, how is updating Spring causing HTTP/2 errors? |
|
Ah, because it requires 4.1.111.Final, which is blocked right now |
|
Actually I'm wrong, Netty is up to date on main, it's only blocked on stable branches 🤔 |
|
So Netty 4.1.111.Final is not compatible with gRPC, and is likely to cause many issues. It's a shame it was merged automatically, but apparently it's flaky in prod, so it was possible for it to be green. I will downgrade and block the update for now, and once gRPC 1.65 is out we can update Netty, and consequently Spring Boot as well. |
npepinpe
requested changes
Jun 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
## Description Netty 4.1.111.Final is incompatible with grpc-java < 1.65.0 and >= 1.51.0. It can introduce buffer corruption at any point, which if you're lucky is detected, but may also go unnoticed and result in garbage and waste of time. Wait until grpc-java releases a compatible version before updating to 4.1.111.Final. Note that this also blocks Spring Boot 3.3.1 which depends on Netty 4.1.111.Final. See: - grpc/grpc-java#11284 (comment) - https://github.com/grpc/grpc-java/releases/tag/v1.64.0 ## Related issues blocks #19581 blocks #19265 blocks #19264 blocks #19259 blocks #19258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.13.3.0->3.3.1Release Notes
spring-projects/spring-boot (org.springframework.boot:spring-boot-maven-plugin)
v3.3.1Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.