Add endpoint to enable exporter #19261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/zeebe
npepinpe
approved these changes
Jun 12, 2024
dist/src/main/java/io/camunda/zeebe/shared/management/ExportersEndpoint.java
Outdated
Show resolved
Hide resolved
zeebe/broker/src/main/java/io/camunda/zeebe/broker/exporter/stream/ExporterDirector.java
Show resolved
Hide resolved
There was a problem hiding this comment.
🤔 Is there no test to check that the director is now idle? What would be the impact if it wasn't and we don't verify this?
There was a problem hiding this comment.
We can test if the state is idle. But it is not adding much value. Testing whether it has stopped all services is a bit more tricky. The main requirement is that once we disable all exporters, we can enable new ones later. This is tested in the ExporterEnableTest.
The impact if it did not stop all services is that is unnecessarily consuming CPU cycles - it reads the log entry for every commit even if there are no exporters to export.
zeebe/qa/integration-tests/src/test/java/io/camunda/zeebe/it/exporter/ExporterEnableTest.java
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
On idle, it stops receiving notification from logstream commits and also stops the distribution service. When new exporters are configured, it will restart exporting again.
ExporterDirector does not close if no exporters are configured. Instead it just goes to an idle state. So the tests that wait for it to be closed is updated.
deepthidevaki
force-pushed
the
dd-19022-gateway-enable-exporter
branch
from
1888509
to
4c30b88
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merge failed due to retrying. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
😭 I'm really unlucky today. Merge failed again due to "self hosted runner lost communication with the server". Retrying.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR combines two things
ExporterDirectordoes not close itself when no exporters are configured. Instead it goes to an idle state, where the actor is still running, but it is not actively doing any tasks. When a new exporter is enabled, it will become active again and starts all necessary services to resume exporting.Related issues
closes #19022
closes #18752