refactor: unit test document hanlding #3142
Open
+80
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Trying to make the unit tests more generic and easier to read - I did the following refactorings:
2.1. name of the
testCase
2.2. all
values
that we are setting in the values.yaml.2.3 all
expected
values (in this case envVars), which should be set after the configmap got rendered.p.s. lets wait for https://github.com/camunda/camunda-platform-helm/pull/3141/files to be merged as it removes the local option.
What's in this PR?
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: