Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove local storage unit test for doc handling #3141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hisImminence
Copy link
Contributor

Which problem does the PR fix?

The local option was removed and can therefore also be removed from the unit test.

related to #3013

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added the version/alpha Camunda applications/cycle version (this is a pointer to alpha) label Mar 9, 2025
@hisImminence hisImminence force-pushed the remove-unit-test-docHandling-local branch from 8ed9e10 to 9af9b86 Compare March 9, 2025 11:31
@hisImminence
Copy link
Contributor Author

@rodrigo-lourenco-lopes / @aabouzaid.

Wondering why this removal was not noticed earlier once the support for local storage was removed. I actually can not see the unit tests running in our CI pipe 😱 - they are not triggered, or do I miss something?

@hisImminence hisImminence changed the title remove local storage unit test as option was removed fix: local storage unit test as option was removed Mar 9, 2025
@hisImminence hisImminence changed the title fix: local storage unit test as option was removed fix: remove local storage unit test for doc handling Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/alpha Camunda applications/cycle version (this is a pointer to alpha)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant