Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changing helper function for identityURL #3084

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: changing helper function for identityURL #3084

wants to merge 4 commits into from
+33 −117

Conversation

hamza-m-masood
Copy link
Contributor

Which problem does the PR fix?

closes: #3083

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version version/alpha Camunda applications/cycle version (this is a pointer to alpha) labels Mar 6, 2025
@hamza-m-masood hamza-m-masood requested a review from a team March 6, 2025 00:49
aabouzaid
aabouzaid requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to use camundaPlatform.identityURL instead of webModeler.identityBaseUrl.

@hamza-m-masood hamza-m-masood requested a review from aabouzaid March 6, 2025 13:17
@hamza-m-masood hamza-m-masood removed the version/8.2 Camunda applications/cycle version label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid Awaiting requested review from aabouzaid

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component/optimize component/web-modeler version/alpha Camunda applications/cycle version (this is a pointer to alpha) version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] populate identity internal URL even if identity is disabled
2 participants
@hamza-m-masood @aabouzaid