Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global.extraManifests support for injecting arbitrary YAML #3050

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

drodriguez-305
Copy link
Contributor

@drodriguez-305 drodriguez-305 commented Mar 3, 2025

Which problem does the PR fix?

closes: #2999

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot added the version/alpha Camunda applications/cycle version (this is a pointer to alpha) label Mar 3, 2025
@drodriguez-305 drodriguez-305 marked this pull request as draft March 3, 2025 23:07
@drodriguez-305
Copy link
Contributor Author

drodriguez-305 commented Mar 3, 2025

@hamza-m-masood was messing around with it feel free to make any changes or disregard completely!

the default would be as a list. just left the example on there that you had mentioned.

global:
  extraManifests: []

@hamza-m-masood
Copy link
Contributor

hamza-m-masood commented Mar 8, 2025

The feature is working now.

@hamza-m-masood hamza-m-masood force-pushed the feat-extramanifest-test branch from 930968f to e1cb31e Compare March 8, 2025 04:27
@hamza-m-masood
Copy link
Contributor

rebased

@hamza-m-masood hamza-m-masood requested a review from a team March 8, 2025 04:42
@hamza-m-masood hamza-m-masood self-assigned this Mar 8, 2025
@hamza-m-masood hamza-m-masood marked this pull request as ready for review March 8, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/alpha Camunda applications/cycle version (this is a pointer to alpha)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add the possibility to define a full manifest through arbitrary data in the values.yaml.
2 participants