Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: standardize identity test client naming for multi-team support #2893

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

ci: standardize identity test client naming for multi-team support #2893

wants to merge 20 commits into from

Conversation

drodriguez-305
Copy link
Contributor

Which problem does the PR fix?

Related to : #2482

What's in this PR?

  • Renamed clients from venom to test for all versions. (8.8 was not included as there is no test currently)
  • Made the test user to be the default venomClientID in our testsuite-core.yaml
    venomClientID: '{{ .TEST_CLIENT_ID | default "test" }}'

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@drodriguez-305 drodriguez-305 added this to the 8.7 Release Cycle milestone Feb 11, 2025
@drodriguez-305 drodriguez-305 self-assigned this Feb 11, 2025
@drodriguez-305 drodriguez-305 linked an issue Feb 11, 2025 that may be closed by this pull request
[TASK] Rename CI test client for Identity #2482
Open
@github-actions github-actions bot added version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version version/alpha Camunda applications/cycle version (this is a pointer to alpha) labels Feb 11, 2025
@drodriguez-305 drodriguez-305 requested a review from a team February 11, 2025 21:21
@drodriguez-305 drodriguez-305 added version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version and removed version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version labels Feb 18, 2025
@drodriguez-305 drodriguez-305 force-pushed the change-venom-identity-user branch 2 times, most recently from d177272 to 2121e3c Compare February 28, 2025 20:44
jessesimpson36
jessesimpson36 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@jessesimpson36 jessesimpson36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.2.34 is a faulty release causing failures in the helm upgrade test. We're ignoring this in the context of this PR

@drodriguez-305 drodriguez-305 force-pushed the change-venom-identity-user branch from 5e8c108 to deb19b9 Compare March 3, 2025 21:28
@drodriguez-305
Copy link
Contributor Author

i'll merge after the release.

drodriguez-305 and others added 16 commits March 6, 2025 14:32
@drodriguez-305
Revert "Revert "fix: rename venomClientID default to test""
49e41a5 
This reverts commit cc0732a.
@drodriguez-305
add ports to keycloak manually for 8.2 integration test
791b16f
@drodriguez-305
add ports to keycloak manually for 8.2 integration test
2682a11
@drodriguez-305
add ports to keycloak manually for 8.2 integration test
6670fe6
@drodriguez-305
add ports to keycloak manually for 8.2 integration test
9f5aace
@drodriguez-305
fix: add port to identity keycloak integration test
b029327
@drodriguez-305
fix: add port to identity keycloak integration test
7fa7832
@jessesimpson36 @drodriguez-305
test: adjust service ports
72f366a
@drodriguez-305
fix: add keycloak port to values integration test
26b43e0
@drodriguez-305
Revert "fix: add keycloak port to values integration test"
6314500 
This reverts commit 80ed9d8.
@jessesimpson36 @drodriguez-305
test: empty
521f7f2
@jessesimpson36 @drodriguez-305
fix: jesse is angry
0ff7fb0
@jessesimpson36 @drodriguez-305
Revert "fix: jesse is angry"
1008fc7 
This reverts commit 8b50be4.
@jessesimpson36 @drodriguez-305
fix: remove service ports patch
b018117
@jessesimpson36 @drodriguez-305
style: remove newlines
8611202
@distro-ci @drodriguez-305
chore: chart chores
a2ef500
@drodriguez-305 drodriguez-305 force-pushed the change-venom-identity-user branch from bf2d9b1 to a2ef500 Compare March 6, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesimpson36 jessesimpson36 jessesimpson36 approved these changes

Assignees

@drodriguez-305 drodriguez-305

Labels
area/ci version/alpha Camunda applications/cycle version (this is a pointer to alpha) version/8.2 Camunda applications/cycle version version/8.3 Camunda applications/cycle version version/8.4 Camunda applications/cycle version version/8.5 Camunda applications/cycle version version/8.6 Camunda applications/cycle version
Projects
None yet
Milestone
8.7 Release Cycle
Development

Successfully merging this pull request may close these issues.

[TASK] Rename CI test client for Identity
2 participants
@drodriguez-305 @jessesimpson36