Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch "DT" symbol to "TS" on npm #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karlhorky
Copy link

First of all, thanks for fetch-jsonp, useful library!

What?

Add a "types" field to package.json, like Jest and other package including their own types.

Why?

On the npm page for fetch-jsonp, there is a "DT" symbol, indicating that the library has 3rd-party DefinitelyTyped types:

Screenshot 2024-07-10 at 15 10 01

The "DT" symbol links to @types/fetch-jsonp, which has a deprecation notice:

This is a stub types definition. fetch-jsonp provides its own type definitions, so you do not need this installed.

Screenshot 2024-07-10 at 15 14 01

npm should report the correct types source for the library, with the blue "TS" symbol as can be seen on the npm page for jest:

341327086-9f27ccc0-6f95-4409-99cc-64cade91d0a0

The jest package includes its own types and the npm page shows the "TS" symbol, even though the package @types/jest also exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant