Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for
fetch-jsonp
, useful library!What?
Add a
"types"
field topackage.json
, like Jest and other package including their own types.Why?
On the npm page for
fetch-jsonp
, there is a "DT" symbol, indicating that the library has 3rd-party DefinitelyTyped types:The "DT" symbol links to
@types/fetch-jsonp
, which has a deprecation notice:npm should report the correct types source for the library, with the blue "TS" symbol as can be seen on the npm page for
jest
:The
jest
package includes its own types and the npm page shows the "TS" symbol, even though the package@types/jest
also exists.