Parser #2353
Open
Parser #2353
+161
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EclecticGriffin
requested changes
Nov 21, 2024
interp/src/debugger/commands/core.rs
Outdated
| self.nodes.clone() | ||
| } | ||
|
|
||
| pub fn from_iter<I>(iter: I) -> ParsePath |
There was a problem hiding this comment.
As clippy points out, there is a trait called FromIterator which you should move this implementation into.
See: https://doc.rust-lang.org/std/iter/trait.FromIterator.html
Comment on lines
+317
to
+319
| pub fn get_path(&self) -> Vec<ParseNodes> { | ||
| self.nodes.clone() | ||
| } |
There was a problem hiding this comment.
Recommend making this a standard accessor which returns a reference to the vec
or a slice and cloning externally when necessary
| @@ -0,0 +1,13 @@ | |||
| root = { "." } | |||
|
|
|||
| seperator = { "-" } | |||
Comment on lines
61
to
69
|
|
||
| // Parse the path | ||
| pub fn parse_path(input_str: &str) -> Result<ParsePath, Error<Rule>> { | ||
| let entries = PathParser::parse(Rule::path, input_str)?; | ||
| let entry = entries.single()?; | ||
|
|
||
| PathParser::path(entry) | ||
| } | ||
|
|
There was a problem hiding this comment.
add #[allow(dead_code)] here for the moment since this PR doesn't use the
function. This will quiet clippy down.
There was a problem hiding this comment.
To fix the size issue change the return type to Box<Error<Rule>> and add
.map_err(Box::new) to the final line
EclecticGriffin
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a parser to process the path we've described such as: ".-0-1-b"