-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[being split up] Implement Rust FFI and testbench integration #2181
Conversation
Ideally I'd like to move the logic in the |
Also closes #2162 |
A TODO thing would be to take advantage of the fact that the verilog incoming is calyx and write a new tester that allows you to interface with calyx components preserving the invariants (in addition to just being able to use cocotb and verilator as currently) |
Waiting on #2193 |
412ea37
to
91abfd2
Compare
fud2 tests failing because of I hack I added before multi-input ops were a thing. @jku20, I assume they are now? |
For some reason, it seems all my commits became unverified? |
Now they're verified again... |
@ethanuppal what's the status of this PR and what would it take to get it merged? |
@rachitnigam I've been working with @EclecticGriffin on using cider2 programmatically; once I have the adder component test working (under |
20d123d
to
eedd816
Compare
@EclecticGriffin when you get a chance, could you take a look at why the interpreter tests are failing? Is it the fix I made to subtraction (which is fuzz-tested to be correct in an example I wrote through calyx FFI!) breaking it due to subtraction underflow? |
This tool is out of date with respect to the way values work in Cider currently. We replaced the janky |
As per @ekiwi I'm going to split this into smaller commits to ease the review process. Unfortunately we will lose the nice semantic history because I didn't make |
tb
,ffi] Implement Rust FFI and testbench integration
This pull request has not seen activity in 14 days and is being marked as stale. If you're continuing work on this, please reply and state how to get this PR in a mergeable state or what issues it is blocked on. If the PR is not ready for review, please mark it as a draft. The PR will be closed in 7 days if there is no further activity. |
I'm not good at fud2 stuff but I think I'm on the right track