Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'wakeword' to 'audiosample' to better reflect the backend table. #45

Closed
wants to merge 1 commit into from
Closed

Changed 'wakeword' to 'audiosample' to better reflect the backend table. #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flask_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def handle_question():
return jsonify(response), SUCCESS


@app.route('/new_data/wakeword', methods=['POST'])
@app.route('/new_data/audiosample', methods=['POST'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go with /audiosample to keep it simple

Copy link
Member

@mfekadu mfekadu Feb 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Waidhoferj what are your thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no preference either way.

def save_a_recording():
"""Given the audio metadata & audio file, resamples it, saves to storage.
"""
Expand Down