Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ML classifier to reject spam events #735

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DGaffney
Copy link

As referenced in my other message, here's an implementation where we can use a classifier to reject spam events. The one thing I don't love is that this requires HTTP requests during an HTTP request, but no way to get around that without putting some other job logic into calagator afaict

Flip label - 1 is legit, 0 is spam
flip bit - 1 is legit, 0 is spam
flip bit - 1 is legit, 0 is spam
flip bit - 1 is legit, 0 is spam
flip bit - 1 is legit, 0 is spam
Copy link
Contributor

@jc00ke jc00ke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

app/models/calagator/event/saver.rb Outdated Show resolved Hide resolved
app/models/calagator/event/saver.rb Show resolved Hide resolved
app/controllers/calagator/application_controller.rb Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
app/services/gpturk_service.rb Show resolved Hide resolved
@DGaffney
Copy link
Author

@jc00ke most of what you're looking for is now here I think - I ran most tests successfully locally, but was running into some chrome version mismatch on selenium tests that were failing. I think they were mostly unrelated, but can't be sure, so you may want to try locally too - yak shaving the version mismatch is something I can do, but will take a bit longer and I wanted to get the code here first so you can check it out. LMK what you think!

Copy link
Contributor

@jc00ke jc00ke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the tests you added! Check out the minor nit on my bad name suggestion 😆

app/services/gpturk_service.rb Outdated Show resolved Hide resolved
app/services/gpturk_service.rb Outdated Show resolved Hide resolved
@DGaffney
Copy link
Author

DGaffney commented Aug 4, 2023

@jc00ke any chance to pull this?

@jc00ke
Copy link
Contributor

jc00ke commented Aug 4, 2023

Hey @DGaffney, I'd like to hear from @reidab before I merge. I should have made that clear previously; sorry!

@jeffmartens
Copy link

What ever happened to this PR? I came here after noticing that a few events in San Francisco have been posted to Calagator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants