Fix setting sqlsrv PK name with qualified table name (#2306)

Co-authored-by: Matthew Peveler <[email protected]>
cakephp · Sep 7, 2024 · b5dab99 · b5dab99
1 parent d55d705
commit b5dab99
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Phinx/Db/Adapter/SqlServerAdapter.php b/src/Phinx/Db/Adapter/SqlServerAdapter.php
@@ -270,7 +270,7 @@ public function createTable(Table $table, array $columns = [], array $indexes =
 
         // set the primary key(s)
         if (isset($options['primary_key'])) {
-            $pkSql = sprintf('CONSTRAINT PK_%s PRIMARY KEY (', $table->getName());
+            $pkSql = sprintf('CONSTRAINT PK_%s PRIMARY KEY (', str_replace('.', '_', $table->getName()));
             if (is_string($options['primary_key'])) { // handle primary_key => 'id'
                 $pkSql .= $this->quoteColumnName($options['primary_key']);
             } elseif (is_array($options['primary_key'])) { // handle primary_key => array('tag_id', 'resource_id')

diff --git a/tests/Phinx/Db/Adapter/SqlServerAdapterTest.php b/tests/Phinx/Db/Adapter/SqlServerAdapterTest.php
@@ -199,6 +199,13 @@ public function testCreateTableWithNoPrimaryKey()
         $this->assertFalse($this->adapter->hasColumn('atable', 'id'));
     }
 
+    public function testCreateFullyQualifiedTable()
+    {
+        (new Table('dbo.qualified_table', [], $this->adapter))->create();
+        $this->assertTrue($this->adapter->hasTable('dbo.qualified_table'));
+        $this->assertTrue($this->adapter->hasPrimaryKey('qualified_table', 'id'));
+    }
+
     public function testCreateTableWithConflictingPrimaryKeys()
     {
         $options = [