Rename build server API #1400
Merged
Rename build server API #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request performs a comprehensive rename of the build server API, changing BuildServerSystem to BuildServer throughout the codebase. The change simplifies the API naming and improves consistency.
Key Changes
- Renamed core interface from
IBuildServerSystemtoIBuildServer - Renamed base class from
BaseBuildServerSystemtoBaseBuildServer - Updated all parameter names, variable names, comments, and documentation to use the new naming convention
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| IBuildServer.cs | Renamed interface from IBuildServerSystem to IBuildServer with updated XML documentation |
| BaseBuildServer.cs | Renamed base class from BaseBuildServerSystem to BaseBuildServer with updated XML documentation |
| BuildServerOrchestrator.cs | Updated field, parameter, variable names and comments from buildServerSystem to buildServer |
| Aliases.cs | Updated all method parameters from buildServerSystem to buildServer with corresponding XML documentation |
| OrchestratorForIssuesFixture.cs | Updated fixture properties and variables from BuildServerSystem to BuildServer |
| OrchestratorForIssueProvidersFixture.cs | Updated fixture properties and variables from BuildServerSystem to BuildServer |
| FakeBuildServerSystemBuilder.cs | File deleted as part of rename |
| FakeBuildServerBuilder.cs | New file replacing FakeBuildServerSystemBuilder with updated naming |
| FakeBuildServer.cs | Renamed class from FakeBuildServerSystem to FakeBuildServer |
| BuildServerOrchestratorTests.cs | Updated property references and parameter names in test assertions |
| BuildServerIntegrationTests.cs | Renamed test class from TestBuildServerSystem to TestBuildServer |
| GitHubActionsBuildsAliases.cs | Updated return type from IBuildServerSystem to IBuildServer |
| GitHubActionsBuildServer.cs | Updated base class from BaseBuildServerSystem to BaseBuildServer |
| AppVeyorBuildsAliases.cs | Updated return type from IBuildServerSystem to IBuildServer |
| AppVeyorBuildServer.cs | Updated base class from BaseBuildServerSystem to BaseBuildServer |
src/Core/Cake.Issues.BuildServer/Cake.Issues.BuildServer.Tests/BuildServerOrchestratorTests.cs
Show resolved
Hide resolved
pascalberger
force-pushed
the
feature/build-server-renaming
branch
from
530ef2b to
77736a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
BuildServerSystemtoBuildServer