Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#733) use existing properties inside omnisharp.json #734

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nils-a
Copy link
Member

@nils-a nils-a commented Oct 13, 2022

Instead of enforcing properties "cake" and "bakeryPath"
case-sensitive.
Closes #733

This is a regression from
cake-build#731
where everything will work fine, if node_modules does
not exist. However, if it does exist the non-zero exit code
will propagate and prevent tsc from running.
By adding a second, "parallel" command to ensureCi
the exit code of that script will always be zero and thus
never prevent tsc from running.
instead of enforcing properties "cake" and "bakeryPath"
case sensitive.
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice workaraound for case sensitivity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modification of omnisharp.json can lead to errors
2 participants