WIP

cake-build · Jan 20, 2025 · a096084 · a096084
1 parent a04a24a
commit a096084
Show file tree

Hide file tree

Showing 15 changed files with 26,708 additions and 6,699 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -21,6 +21,10 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: '6.0.x'
+      - name: Install the .NET 8 SDK
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '8.0.x'
       - name: Run a specific Cake script
         uses: ./
         with:
@@ -79,7 +83,7 @@ jobs:
         uses: ./
         with:
           cake-bootstrap: auto
-          cake-version: 1.0.0
+          cake-version: 1.3.0
           script-path: ${{ env.script-directory }}/module.cake
       - name: Remove the tools directory
         run: rm -rf ${{ env.tools-directory }}
@@ -88,7 +92,7 @@ jobs:
         uses: ./
         with:
           cake-bootstrap: auto
-          cake-version: 0.38.5
+          cake-version: 0.5.0
           script-path: ${{ env.script-directory }}/build.cake
           target: Successful-Task
       - name: Remove the tools directory
@@ -98,7 +102,7 @@ jobs:
         uses: ./
         with:
           cake-bootstrap: explicit
-          cake-version: 1.0.0
+          cake-version: 1.3.0
           script-path: ${{ env.script-directory }}/module.cake
       - name: Remove the tools directory
         run: rm -rf ${{ env.tools-directory }}
@@ -107,7 +111,7 @@ jobs:
         uses: ./
         with:
           cake-bootstrap: explicit
-          cake-version: 0.38.5
+          cake-version: 0.5.0
           script-path: ${{ env.script-directory }}/module.cake
       - name: Remove the tools directory
         run: rm -rf ${{ env.tools-directory }}
@@ -116,14 +120,14 @@ jobs:
         uses: ./
         with:
           cake-bootstrap: skip
-          cake-version: 1.0.0
+          cake-version: 1.3.0
           script-path: ${{ env.script-directory }}/build.cake
           target: Successful-Task
       - name: Run skip bootstrapping of Cake modules (Cake < 1.0.0)
         uses: ./
         with:
           cake-bootstrap: skip
-          cake-version: 0.38.5
+          cake-version: 0.5.0
           script-path: ${{ env.script-directory }}/build.cake
           target: Successful-Task
       - name: Run with a specific verbosity level

diff --git a/__tests__/cake.test.ts b/__tests__/cake.test.ts
@@ -19,7 +19,7 @@ describe('When running a script successfully using the global Cake tool', () =>
   const fakeWhich = which as jest.MockedFunction<typeof which>;
   const fakeExec = exec as jest.MockedFunction<typeof exec>;
 
-  beforeAll(async () => {
+  beforeAll(() => {
     fakeWhich.mockReturnValue(Promise.resolve('/usr/bin/dotnet-cake'));
     fakeExec.mockReturnValue(Promise.resolve(0));
   });
@@ -60,7 +60,7 @@ describe('When running a script successfully using the global Cake tool', () =>
 describe('When running a script successfully using the local Cake tool', () => {
   const fakeExec = exec as jest.MockedFunction<typeof exec>;
 
-  beforeAll(async () => {
+  beforeAll(() => {
     fakeExec.mockReturnValue(Promise.resolve(0));
   });
 
@@ -126,7 +126,7 @@ describe('When failing to run a script using the local Cake tool', () => {
 describe('When bootstrapping a script successfully using the local Cake tool', () => {
   const fakeExec = exec as jest.MockedFunction<typeof exec>;
 
-  beforeAll(async () => {
+  beforeAll(() => {
     fakeExec.mockReturnValue(Promise.resolve(0));
   });
 
@@ -156,7 +156,7 @@ describe('When failing to bootstrap a script using the local Cake tool', () => {
 describe('When running a script successfully using the tool manifest', () => {
   const fakeExec = exec as jest.MockedFunction<typeof exec>;
 
-  beforeAll(async () => {
+  beforeAll(() => {
     fakeExec.mockReturnValue(Promise.resolve(0));
   });
 
@@ -197,7 +197,7 @@ describe('When running a Cake Frosting project successfully', () => {
   const fakeExec = exec as jest.MockedFunction<typeof exec>;
   const fakeToolsDirectory = new ToolsDirectory();
 
-  beforeAll(async () => {
+  beforeAll(() => {
     fakeExec.mockReturnValue(Promise.resolve(0));
   });
 

diff --git a/__tests__/cakeRelease.test.ts b/__tests__/cakeRelease.test.ts
@@ -2,16 +2,16 @@ import * as http from '@actions/http-client';
 import * as cakeRelease from '../src/cakeRelease';
 
 describe('When retrieving the latest Cake version', () => {
-  beforeAll(async () => {
+  beforeAll(() => {
     jest
       .spyOn(http.HttpClient.prototype, 'getJson')
-      .mockImplementation(async () => ({
+      .mockResolvedValue({
         statusCode: 200,
         result: {
           tag_name: 'v1.0.0'
         },
         headers: {}
-      }));
+      });
   });
 
   test('it should return the latest version number from GitHub', async () => {
@@ -20,16 +20,16 @@ describe('When retrieving the latest Cake version', () => {
 });
 
 describe('When retrieving the latest Cake version without the \'v\' prefix', () => {
-  beforeAll(async () => {
+  beforeAll(() => {
     jest
       .spyOn(http.HttpClient.prototype, 'getJson')
-      .mockImplementation(async () => ({
+      .mockResolvedValue({
         statusCode: 200,
         result: {
           tag_name: '1.0.0'
         },
         headers: {}
-      }));
+      });
   });
 
   test('it should return the latest version number from GitHub', async () => {
@@ -38,14 +38,14 @@ describe('When retrieving the latest Cake version without the \'v\' prefix', ()
 });
 
 describe('When failing to retrieve the latest Cake version due to a GitHub error', () => {
-  beforeAll(async () => {
+  beforeAll(() => {
     jest
       .spyOn(http.HttpClient.prototype, 'getJson')
-      .mockImplementation(async () => ({
+      .mockResolvedValue({
         statusCode: 500,
         result: {},
         headers: {}
-      }));
+      });
   });
 
   test('it should return null', async () => {
@@ -60,14 +60,14 @@ describe('When failing to retrieve the latest Cake version due to a GitHub error
 });
 
 describe('When failing to retrieve the latest Cake version due to an empty response from GitHub', () => {
-  beforeAll(async () => {
+  beforeAll(() => {
     jest
       .spyOn(http.HttpClient.prototype, 'getJson')
-      .mockImplementation(async () => ({
+      .mockResolvedValue({
         statusCode: 200,
         result: {},
         headers: {}
-      }));
+      });
   });
 
   test('it should return null', async () => {
@@ -76,16 +76,16 @@ describe('When failing to retrieve the latest Cake version due to an empty respo
 });
 
 describe('When failing to retrieve the latest Cake version due to a missing tag name in the GitHub response', () => {
-  beforeAll(async () => {
+  beforeAll(() => {
     jest
       .spyOn(http.HttpClient.prototype, 'getJson')
-      .mockImplementation(async () => ({
+      .mockResolvedValue({
         statusCode: 200,
         result: {
           tag_name: null
         },
         headers: {}
-      }));
+      });
   });
 
   test('it should return null', async () => {
@@ -94,16 +94,16 @@ describe('When failing to retrieve the latest Cake version due to a missing tag
 });
 
 describe('When failing to retrieve the latest Cake version due to an empty tag name in the GitHub response', () => {
-  beforeAll(async () => {
+  beforeAll(() => {
     jest
       .spyOn(http.HttpClient.prototype, 'getJson')
-      .mockImplementation(async () => ({
+      .mockResolvedValue({
         statusCode: 200,
         result: {
           tag_name: ''
         },
         headers: {}
-      }));
+      });
   });
 
   test('it should return null', async () => {

diff --git a/__tests__/cakeTool.test.ts b/__tests__/cakeTool.test.ts
@@ -21,7 +21,7 @@ describe('When installing the Cake Tool based on the tool manifest', () => {
     expect(fakeRestoreTool).toHaveBeenCalled();
   });
 
-  test('it should not explicitly install any local tools', async () => {
+  test('it should not explicitly install any local tools', () => {
     expect(fakeInstallLocalTool).not.toHaveBeenCalled();
   });
 });

diff --git a/__tests__/dotnet.test.ts b/__tests__/dotnet.test.ts
@@ -59,8 +59,8 @@ describe('When installing a local tool in a directory where it already exists',
     fakeExec.mockReturnValue(Promise.resolve(0));
   });
 
-  test('it should not attempt to install the specified tool in the same directory', () => {
-    dotnet.installLocalTool('The.Tool', 'dotnet-tool', directoryWithTool);
+  test('it should not attempt to install the specified tool in the same directory', async () => {
+    await dotnet.installLocalTool('The.Tool', 'dotnet-tool', directoryWithTool);
     expect(fakeExec).not.toHaveBeenCalledWith(
       'dotnet tool install',
       ['--tool-path', directoryWithTool.path, 'The.Tool']);

diff --git a/__tests__/main.test.ts b/__tests__/main.test.ts
@@ -27,6 +27,7 @@ describe('When running the action without any input arguments', () => {
 
   test('it should create the tools directory', async () => {
     await run();
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     expect(fakeToolsDirectory.prototype.create).toHaveBeenCalled();
   });
 
@@ -276,7 +277,7 @@ describe('When the script fails with an Error object', () => {
   const fakeRunScript = cake.runScript as jest.MockedFunction<typeof cake.runScript>;
 
   beforeAll(() => {
-    fakeRunScript.mockImplementation(async () => {
+    fakeRunScript.mockImplementation(() => {
       throw new Error('the error message');
     });
   });
@@ -292,7 +293,8 @@ describe('When the script fails with a string', () => {
   const fakeRunScript = cake.runScript as jest.MockedFunction<typeof cake.runScript>;
 
   beforeAll(() => {
-    fakeRunScript.mockImplementation(async () => {
+    fakeRunScript.mockImplementation(() => {
+      // eslint-disable-next-line @typescript-eslint/only-throw-error
       throw 'the error message';
     });
   });