log: support d (day) unit in roll_interval log rotation directive#7889
Open
mohammed90 wants to merge 3 commits into
Open
log: support d (day) unit in roll_interval log rotation directive#7889mohammed90 wants to merge 3 commits into
d (day) unit in roll_interval log rotation directive#7889mohammed90 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally fixed in #7865
roll_intervalwas usingtime.ParseDurationwhich doesn't understand thed(day) unit, causingroll_interval 1dto fail at startup despite Caddy's duration conventions supporting it.Changes
FileWriter.RollInterval: Changed fromtime.Durationtocaddy.Duration— also fixes JSON config support for thedunitUnmarshalCaddyfile: Usecaddy.ParseDurationinstead oftime.ParseDurationforroll_intervalparsingOpenWriter: Castcaddy.Duration→time.Durationwhen passing to timberjack'sRotationIntervalTestCaddyfile_RollIntervalcovering1d,24h,30m,1.5d, and invalid inputAssistance Disclosure
Code generated by GitHub Copilot coding agent (claude-sonnet-4.6), reviewed and verified by the operator.