reverseproxy: use xxhash.Sum64String in load balancer hashing#7846
Open
jvoisin wants to merge 1 commit into
Open
reverseproxy: use xxhash.Sum64String in load balancer hashing#7846jvoisin wants to merge 1 commit into
jvoisin wants to merge 1 commit into
Conversation
The hash helper used by hostByHashing (ip_hash, header, cookie, and query hashing policies) created a new xxhash.Digest and converted the input to []byte on every call, i.e. per upstream per request. Replace it with the stateless xxhash.Sum64String, which hashes the string in a single pass. Adds a BenchmarkHostByHashing benchmark, as per policy, even though it's a tad silly. The only change is sec/op (484.2n -> 407.3n (-15.87%)) from skipping the digest struct initialization and Write bookkeeping. Allocations are unchanged, since escape analysis already stack-allocated the Digest and the []byte conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hash helper used by hostByHashing (ip_hash, header, cookie, and query hashing policies) created a new xxhash.Digest and converted the input to []byte on every call, i.e. per upstream per request. Replace it with the stateless xxhash.Sum64String, which hashes the string in a single pass.
Adds a BenchmarkHostByHashing benchmark, as per policy, even though it's a tad silly. The only change is sec/op (484.2n -> 407.3n (-15.87%)) from skipping the digest struct initialization and Write bookkeeping. Allocations are unchanged, since escape analysis already stack-allocated the Digest and the []byte conversion.
Assistance Disclosure
"No AI was used."