Add 3 more sections to election summary page

[ckingbailey]

Partial resolution of #364

Adds

• Who is contributing to races on this ballot?
• Candidates with the largest proportion of small contributions (under $100)
• Where is the money coming from?
  to the election summary page.

Does not add Top 5 Spenders. We're waiting for the data from the backend team for that one.

Previews

Large screens

Small screens

[anlawyer]

Should the amount be assigned to the source variable that comes out of the for loop here? Or is this correct, in order to calculate/set the max variable?

[ckingbailey]

Looks like both of these loops could be removed as the max value is now provided at the key total_contributions.

[anlawyer]

Above, you have this line written as:

{% for contribution_type in election_totals['contributions_by_type'] %}

Is there a reason for the difference?

[ckingbailey]

No reason. I don't know why we wound up with a mix of square bracket and dot notation in this file. Dot would be consistent with the rest of the code, I think

[anlawyer]

Great! I ❤️ consistency.

[anlawyer]

Couple more things:

• Any idea why the candidate names under "with the largest proportion of small contributions" have commas after each name/link?
• About the design... the fonts for the headers on this summary page feel unnecessarily large to me. This is especially evident in the mobile views, but I think even in the normal desktop view, the headers each seem so much bigger than the text in the nav on the side, it feels a little awkward to me. What do you think?

[ckingbailey]

• Any idea why the candidate names under "with the largest proportion of small contributions" have commas after each name/link?

Looks like it's supposed to be Candidate Name, Office but the office is missing from the data. The comma is left over from the dummy data, which included the office. Pinging @mikeubell here and on the backend.

• About the design... the fonts for the headers on this summary page feel unnecessarily large to me. This is especially evident in the mobile views, but I think even in the normal desktop view, the headers each seem so much bigger than the text in the nav on the side, it feels a little awkward to me. What do you think?

Now that you point it out, I agree they look too big on mobile. They're the same size as candidate's data headings, like "Contributions", "Expenses", which are h2. Maybe they look big because they're long lines of text, instead of compact headings like "Expenses".

How's h3 look?

desquetop

mobíl

[anlawyer]

Now that you point it out, I agree they look too big on mobile. They're the same size as candidate's data headings, like "Contributions", "Expenses", which are h2. Maybe they look big because they're long lines of text, instead of compact headings like "Expenses".

How's h3 look?

I like that better! The h2 compared to the size of the text in the side nav also just seemed awkward, maybe out of place? Good point about it being for longer phrases than just one word, I think the h3 is good. What do you think about changing the title of the page ("Data for Oakland Election...") to be an h2 instead of (I assume) the h1? It just seems so massive compared to everything else on the page.

[ckingbailey]

What do you think about changing the title of the page ("Data for Oakland Election...") to be an h2 instead of (I assume) the h1? It just seems so massive compared to everything else on the page.

Looks 🍕 ✌️ me

desk

mōb

[anlawyer]

[ckingbailey]

Office titles are innnnnnn 🎉 !