-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add itemSaver setting. #2107
add itemSaver setting. #2107
Conversation
Signed-off-by: scorbett123 <[email protected]>
Hello, can you explain to me how to install this? (I don't speak English, so forgive me for the grammar ) |
how to specifically install this "the top modification". sorry i'm a big shit |
|
From what you said I did understand anything lol, I don't understand java, english, and this site. But I was able to understand that as the modifications have to be done in the source, that is, I understood what should be changed and where it should be changed ("source" .zip), however, how I transform a .zip (source) file into .jar? If I'm pissing you off, send me to hell. = ( |
I told you how. Run these in a terminal
|
I understand. To do this, use the terminal? Is it on this site or is it a specific program? I've never used google translators so much in my life lol. Edit:Linux or Windows? |
A terminal on Linux. Use |
I'm doing it, but i have a question, the end result, will it be a mod forge or fabric? I'm using "https://github.com/cabaletta/baritone/releases> v1.6.1> Source code |
The Baritone repo is Forge by default. |
and on this walk, the source I took gave 3 errors package net.minecraft.init does not exist with the original files "settings;toolset" everything works, with the modified error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed
:compileApiJava
Settings.java
package net.minecraft.init does not exist
cannot find symbol class Vec3i
cannot find symbol class Vec3i #
////////////////////////
21:29:57: Executing task 'prepareRunClient'...
Task :buildSrc:compileJava UP-TO-DATE
Task :buildSrc:compileGroovy NO-SOURCE
Task :buildSrc:processResources NO-SOURCE
Task :buildSrc:classes UP-TO-DATE
Task :buildSrc:jar UP-TO-DATE
Task :buildSrc:assemble UP-TO-DATE
Task :buildSrc:compileTestJava NO-SOURCE
Task :buildSrc:compileTestGroovy NO-SOURCE
Task :buildSrc:processTestResources NO-SOURCE
Task :buildSrc:testClasses UP-TO-DATE
Task :buildSrc:test NO-SOURCE
Task :buildSrc:check UP-TO-DATE
Task :buildSrc:build UP-TO-DATE
Configure project :
New Dep: com.github.ImpactDevelopment:Vanilla:1.16.2_mapped_snapshot_20200813-1.16.1
Task :compileApiJava FAILED
C:\Users\helei\Desktop\1\src\api\java\baritone\api\Settings.java:24: error: package net.minecraft.init does not exist
import net.minecraft.init.Blocks;
^
C:\Users\helei\Desktop\1\src\api\java\baritone\api\Settings.java:26: error: cannot find symbol
import net.minecraft.util.math.Vec3i;
^
symbol: class Vec3i
location: package net.minecraft.util.math
C:\Users\helei\Desktop\1\src\api\java\baritone\api\Settings.java:808: error: cannot find symbol
public final Setting buildRepeat = new Setting<>(new Vec3i(0, 0, 0));
^
symbol: class Vec3i
location: class Settings
3 errors
FAILURE: Build failed with an exception.
- What went wrong:
Execution failed for task ':compileApiJava'.
Compilation failed; see the compiler error output for details.
-
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. -
Get more help at https://help.gradle.org
Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 1s
1 actionable task: 1 executed
21:29:59: Task execution finished 'prepareRunClient'.
///////////////////////
The issue that you are having is that you are trying to use the 1.12 branch (master) and compile to 1.16. This unfortunately doesn't work, if you give me a minute I will compile a version for you. |
Here you go, inside are all of the different jars. |
Good morning my friend, it opens(any of the versions within "toolsSaver (2).zip), however when entering a world, either solo, or on a server it crashes * I believe I was not using the master, I was using >>> Crash report*: I try 1.16.1; 1.16.2; 1.16.3 |
yea, probably running into #2115. |
Why does a single change cause so much trouble? |
It doesn't |
The forge build works just fine for me |
Man I love you from the bottom of my heart, your version worked! If you can, to satisfy my curiosity, tell me what you did, I would be even more grateful. I was unable to compile, much less use what the young man above did. Valeu negão, tu é o cara, muito obrigado. |
What I did (for Linux and likely also Mac):
|
@scorbett123 when testing this I noticed that it still breaks tools whenever they are in slot 0 and there is no other tool on the hotbar because it uses slot 0 as a fallback. |
…n the slot. Signed-off-by: Sam Corbett <[email protected]>
I changed the getDamage thing, now it hates the l in value for some reason, which it did already but why it would hate the middle of a word is beyond me. |
fixed, compiles but still breaks tools |
Use this jar then. It works however is slightly outdated. |
I do not encounter the issue mentioned with slot 0. This pull request should be merged anyways, even if there is a small edgecase bug, because it provides a major advantage to baritone. I found my way here because I required a tool saver |
@recursivetree The issue has been fixed in my latest commit. |
closes #1354 |
you need to edit that into the initial comment for github to actually link the issue |
Hi, i was just wondering if this also works with the fabric 1.16.4 version of baritone. I'm new to all of this so following the conversation was quite hard. What I understood was that there was toolsaver for the forge version and that you needed to do something special to integrate it. Even after reading the article in the link mentionned above I could'nt make anything of it. Can you help me? |
You would have to build it for fabric, you would probably have to merge it into 1.16 yourself, make sure that you do it onto the 1.16 branch and run it as baritone.fabric_build. |
Thank you for your fast reply but i have no clue on how to do it. Is there any chance you could do it for me or give me a tutorial? |
I will just do it for you, it is easier for all of us. Give me a bit. |
baritone-1.6.2.zip |
I have tested it for minecraft version 1.16.4 with golden shovels because of their low durability. out of 6 tests I experienced 1 gamecrash (probably due to my pc running autocad on the background). In all of the tests 3 out of 3 shovels were broken. Is there some commandline i have to enter in game before using to change a setting because i didn't know if i had to. |
make sure to enable the itemSaver setting. |
After toggeling the itemsaver setting to true the program still broke all 3 shovels. Is it possible that the program saves the tools when they are at 0 durability? If so is there a way to set a specific durability number at witch it saves the tool? |
Unfortunately, I don't know what is causing you issue, unless there is some dramatic change from 1.12.2 to 1.16, however as you can see it has worked for others, there isn't a way to choose the health of it stopping using it, try it with another tool, but, yea idk. |
Alright, anyways big thank you for the help, ur a real hero ;) |
@leijurv Is there any reason you aren't merging this? It seems to be wanted. |
Thanks |
generally fine to ping me if i've missed something (e.g. if no one has raised any issues and it's been a week or two since the last update) :) |
Can I install the itemsaver for Forge 1.16.5?I saw you posted here zip files with Baritone like dit.zip, toolsSaver.2, baritone-1.6.2 and more but these jar files doesn't worked for me, and some of them was for Fabric, so... not useful for me. Downloaded the zip files for 1.16.1 and 1.16.2 and I wanted to try it on 1.16.5, so I installed them in my Forge mods folder and I tried commands like Actually I wanted to install Impact client, but sadly Impact client isn't free for 1.16.5 yet. Let's try the free way without Impact. I don't know how you are doing this, but can anyone give me the jar file with toolsaver/itemsaver for Forge 1.16.5 please? Can I just use someway the Im really confused, I don't know why Baritone doesn't add these settings officially for all users. They're soo many, so why don't add more? :D |
It has been merged, so download the latest 1.16 release, at the time out writing this is 1.6.3 |
Oh yeahh, cool. Github is a complex thing that I still need to learn to use. |
No, not really. The latest release obviously doesn't contain features newer than the release itself. And in addition it might take a while until a feature is actually ported to the newer mc versions, so the date check only reliably works for master (1.12.2). Did you check it is released @scorbett123? I can't even find where it was merged upwards. |
The latest 1.16 release was on February 5th, this was merged the day after, the only other release after 1.6.3 was 1.2.15 which has this, but there are no 1.16 releases with this unfortunately |
Wait, sorry just checked the merge date and assumed it was just before |
Bruh... :( so that's why I didn't found it in newest version... |
stops baritone using a item when it gets down to 1 durability.
fixes #997
closes #1354