add mineOnlyExposedOres setting #1995

scorbett123 · 2020-09-04T09:57:01Z

adds an exposed Ores only setting.
if there is air no air on any side then it removes it from the goal.
fixes #1168

fee1-dead

LGTM, but why not have an integer setting since there are servers that hide ores except touches transparent block in a radius of two.

And, blocks like water, lava are see-through too and don't forget to include them.

pozhiloy-enotik · 2020-09-04T14:56:53Z

Love you!

scorbett123 · 2020-09-04T17:43:53Z

converted to draft due to a bug in the latest commit.

5HT2 · 2020-09-04T19:44:20Z

src/api/java/baritone/api/Settings.java

+    /**
+     * When allowOnlyExposedOres is enabled this is the distance around to search.
+     * <p>
+     * I recommend keeping this value low as the amount of blocks that need to be scanned increases exponentially.


Rephrase this to be like

- * I recommend keeping this value low as the amount of blocks that need to be scanned increases exponentially. + * It is recommended to keep this value low, as it exponentially increases calculation times.

5HT2 · 2020-09-04T19:44:54Z

src/main/java/baritone/process/MineProcess.java

@@ -409,6 +410,8 @@ private void addNearby() {
                // remove any that are implausible to mine (encased in bedrock, or touching lava)
                .filter(pos -> MineProcess.plausibleToBreak(ctx, pos))

+                .filter(pos -> isNextToAir(ctx, pos))


Shouldn't this only calculate when the setting is enabled?

src/main/java/baritone/process/MineProcess.java

5HT2 · 2020-09-04T19:45:48Z

src/main/java/baritone/process/MineProcess.java

+    }
+
+    public static boolean isTransparent(BlockPos pos, CalculationContext ctx) {
+        IBlockState blockState = ctx.bsi.get0(pos);


are you sure get0 is the correct method here?

what do you suggest to use instead. If you use just get() then you get illegal state exceptions due to running it on the wrong thread. This is also the same as in the method above where it sees if it is plausible to break.

I believe get0 is correct in this case.

leijurv · 2020-09-07T20:13:11Z

src/main/java/baritone/process/MineProcess.java

+        return blockState.getBlock() == Blocks.AIR ||
+                blockState.getBlock() == Blocks.FLOWING_LAVA ||
+                blockState.getBlock() == Blocks.FLOWING_WATER ||
+                blockState.getBlock() == Blocks.WATER;


This helper isTransparent belongs in MovementHelper. I believe there may already be something equivalent there, but I'm not certain.

leijurv · 2020-09-07T20:16:32Z

src/main/java/baritone/process/MineProcess.java

@@ -452,4 +466,86 @@ public void mine(int quantity, BlockOptionalMetaLookup filter) {
            rescan(new ArrayList<>(), new CalculationContext(baritone));
        }
    }
+
+    public static boolean makeSphere(BlockPos pos, double radius, CalculationContext ctx) {


This is extreme cringe.

Literally everything about this function is cringe.

What is the use case for this? Ignore enteerman idk who that is.

Can't this be as simple as like:

for (int dx = -1; dx <= 1; dx++) { for (int dy = -1; dy <= 1; dy++) { for (int dz = -1; dz <= 1; dz++) { if (MovementHelper.isTransparent(pos.add(dx,dy,dz))) { return false; } } } }

leij's example is how I was doing spheres and enteerman or someone made fun of it :clown:

enteerman is the real clown then?

this isn't intended to be a sphere, why would it be?

yeah it shouldn't be a sphere

i am bad at english and sorry if i didnt explain it well. It wasn't intended to be a sphere. just on some servers that blocks that are two blocks from a transparent block are all legit. I think hypixel does that in UHC so you can check that out. You can ignore me, I don't care. I sketched this out and this is how is should work: https://imgur.com/0O7BkWt

I dont know why this method is large but just take the 6 blocks that are adjacent to the block, and take adjacents of the adjacents, to check if it is air.

Or use ur method idk i dont play the game anymore, ask someone else's opinion on this

for me @leijurv's method looks way better but it only checks the direct and diagonal neighbours. I'd rather use

for (int dx = -radius; dx <= radius; dx++) { for (int dy = -radius; dy <= radius; dy++) { for (int dz = -radius; dz <= radius; dz++) { if (Math.abs(dx) + Math.abs(dy) + Math.abs(dz) <= radius && MovementHelper.isTransparent(pos.add(dx,dy,dz))) { return true; } } } }

to check all blocks that have a manhattan distance of at most radius (I think that is was @Enteerman wants to show with his image)

scorbett123 · 2020-09-08T16:40:48Z

force pushing due to pushing the wrong commits earlier.

Signed-off-by: scorbett123 <[email protected]>

Signed-off-by: Sam Corbett <[email protected]>

ZacSharp · 2020-09-08T17:40:53Z

src/api/java/baritone/api/Settings.java

+    /**
+     * When allowOnlyExposedOres is enabled this is the distance around to search.
+     * <p>
+     * It is recommended to keep this value low, as it exponentially increases calculation times and also to keep the


this sentence is incomplete and the amount of checked blocks does not increase exponentially but by (approximately) 1.3*r**3 + 2*r**2 + 2.6*r + 1. That is cubically

Signed-off-by: Sam Corbett <[email protected]>

leijurv

LGTM, fix formatting to match baritone style and i'll merge

leijurv · 2020-10-14T18:06:42Z

src/main/java/baritone/pathing/movement/MovementHelper.java

@@ -562,4 +562,11 @@ static PlaceResult attemptToPlaceABlock(MovementState state, IBaritone baritone,
    enum PlaceResult {
        READY_TO_PLACE, ATTEMPTING, NO_OPTION;
    }
+    public static boolean isTransparent(Block b) {
+
+        return b== Blocks.AIR ||


leijurv · 2020-10-14T18:06:52Z

src/main/java/baritone/process/MineProcess.java

@@ -409,6 +410,13 @@ private void addNearby() {
                // remove any that are implausible to mine (encased in bedrock, or touching lava)
                .filter(pos -> MineProcess.plausibleToBreak(ctx, pos))

+                .filter(pos -> {
+                    if (Baritone.settings().allowOnlyExposedOres.value)


plz use { in the if

leijurv · 2020-10-14T18:07:04Z

src/main/java/baritone/process/MineProcess.java

+            for (int dy = -radius; dy <= radius; dy++) {
+                for (int dz = -radius; dz <= radius; dz++) {
+                    if (Math.abs(dx) + Math.abs(dy) + Math.abs(dz) <= radius
+                            && MovementHelper.isTransparent(ctx.getBlock(pos.getX()+dx, pos.getY()+dy, pos.getZ()+dz))) {


run through autoformatter? put spaces before and after each +

leijurv · 2020-10-14T18:43:12Z

@scorbett123 wait what, why did you rearrange those functions and classes? it makes the diff much bigger for no reason. can we leave the order the same and just add the new function? like how it was an hour ago?

scorbett123 · 2020-10-14T18:45:00Z

Sorry, didn't mean to, something went wrong when committing, I think it might have been my auto formatter.

leijurv · 2020-10-14T18:45:55Z

ohh yea, that's true intellij has this rearrange entries option that i think you gotta untick

scorbett123 · 2020-10-14T18:57:13Z

is this better?

leijurv · 2020-10-14T18:59:12Z

almost haha just one thing can you add curly braces to the if? 😹

Signed-off-by: scorbett123 <[email protected]>

scorbett123 · 2020-10-14T19:01:37Z

Sorry, in my fourth attempt to fix the formatting and failing with using git I obviously forgot about those.

fee1-dead suggested changes Sep 4, 2020

View reviewed changes

scorbett123 marked this pull request as draft September 4, 2020 17:43

5HT2 suggested changes Sep 4, 2020

View reviewed changes

scorbett123 marked this pull request as ready for review September 5, 2020 16:07

leijurv reviewed Sep 7, 2020

View reviewed changes

scorbett123 closed this Sep 8, 2020

scorbett123 reopened this Sep 8, 2020

scorbett123 force-pushed the exposedOres branch from 32c8f70 to 75886b2 Compare September 8, 2020 16:46

scorbett123 added 5 commits September 8, 2020 17:47

add mineOnlyExposedOres setting

bcbfca1

Signed-off-by: scorbett123 <[email protected]>

need to remove diagonals, however this does most of what you suggest.

063f698

Signed-off-by: scorbett123 <[email protected]>

make the ability to turn it off.

547db3a

Signed-off-by: Sam Corbett <[email protected]>

move is transparent to movement helper and circle maker

071243b

Merge https://github.com/cabaletta/baritone into exposedOres

80e4852

scorbett123 force-pushed the exposedOres branch from 75886b2 to 80e4852 Compare September 8, 2020 16:49

ZacSharp suggested changes Sep 8, 2020

View reviewed changes

fix javadoc.

6125105

Signed-off-by: Sam Corbett <[email protected]>

leijurv requested changes Oct 14, 2020

View reviewed changes

scorbett123 force-pushed the exposedOres branch from 51177e1 to f3837f5 Compare October 14, 2020 18:56

fix formatting

39cfebe

Signed-off-by: scorbett123 <[email protected]>

scorbett123 force-pushed the exposedOres branch from f3837f5 to 39cfebe Compare October 14, 2020 19:00

leijurv merged commit 5a5d119 into cabaletta:master Oct 14, 2020

scorbett123 deleted the exposedOres branch October 15, 2020 07:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add mineOnlyExposedOres setting #1995

add mineOnlyExposedOres setting #1995

scorbett123 commented Sep 4, 2020

fee1-dead left a comment

pozhiloy-enotik commented Sep 4, 2020

scorbett123 commented Sep 4, 2020

5HT2 Sep 4, 2020

5HT2 Sep 4, 2020

leijurv Sep 7, 2020

5HT2 Sep 4, 2020

scorbett123 Sep 5, 2020

leijurv Sep 7, 2020

leijurv Sep 7, 2020

leijurv Sep 7, 2020

5HT2 Sep 7, 2020

leijurv Sep 7, 2020

5HT2 Sep 7, 2020

leijurv Sep 7, 2020

fee1-dead Sep 8, 2020

fee1-dead Sep 8, 2020

fee1-dead Sep 8, 2020

ZacSharp Sep 8, 2020 •

edited

Loading

scorbett123 commented Sep 8, 2020 •

edited

Loading

ZacSharp Sep 8, 2020 •

edited

Loading

leijurv left a comment

leijurv Oct 14, 2020

leijurv Oct 14, 2020

leijurv Oct 14, 2020

leijurv commented Oct 14, 2020

scorbett123 commented Oct 14, 2020

leijurv commented Oct 14, 2020

scorbett123 commented Oct 14, 2020

leijurv commented Oct 14, 2020

scorbett123 commented Oct 14, 2020

add mineOnlyExposedOres setting #1995

add mineOnlyExposedOres setting #1995

Conversation

scorbett123 commented Sep 4, 2020

fee1-dead left a comment

Choose a reason for hiding this comment

pozhiloy-enotik commented Sep 4, 2020

scorbett123 commented Sep 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

😹

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZacSharp Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

scorbett123 commented Sep 8, 2020 • edited Loading

ZacSharp Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

leijurv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leijurv commented Oct 14, 2020

scorbett123 commented Oct 14, 2020

leijurv commented Oct 14, 2020

scorbett123 commented Oct 14, 2020

leijurv commented Oct 14, 2020

scorbett123 commented Oct 14, 2020

ZacSharp Sep 8, 2020 •

edited

Loading

scorbett123 commented Sep 8, 2020 •

edited

Loading

ZacSharp Sep 8, 2020 •

edited

Loading