Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tool in github action for mvn build #75

Merged

Conversation

sheridancbio
Copy link
Contributor

attempt to fix failing action step

@sheridancbio
Copy link
Contributor Author

Updating the version of advanced-security third party tool did not reliably fix the failures. The upload of the dependency tree seems to succeed sometimes and fail sometimes (under either version of the tool). Because the tool behavior is inconsistent, I believe we should not make a successful completion of this step in the git action required. If the attempt fails, the automated checks could still be made to pass.

- job does not fail if dependency upload fails
@sheridancbio sheridancbio force-pushed the fix-advanced-security-dependency branch from f615456 to 76cd259 Compare February 24, 2025 22:05
@sheridancbio sheridancbio requested a review from inodb February 24, 2025 22:22
@inodb inodb requested a review from zainasir February 25, 2025 12:23
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable 👍

Any clue why it fails occasionally? Is it a permission issue (e.g. can't do it from fork) or kinda random?

@inodb inodb merged commit 5262eb1 into cBioPortal:main Feb 25, 2025
2 checks passed
@sheridancbio sheridancbio deleted the fix-advanced-security-dependency branch February 28, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants