-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: switch over to webpack-dev-server #105
Closed
airtonix
wants to merge
15
commits into
c8r:master
from
airtonix:feature/104-replace-webpack-serve-with-webpack-dev-server
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5361ff8
Fix: switch over to webpack-dev-server
airtonix 4ad1882
Fix: remove koa-connect... no longer need it
airtonix 94739c6
Fix: use existing debug flag
airtonix 02c6842
Fix: update snapshots
airtonix 32be9fc
Fix: downgrade react-live to avoid #108
airtonix 00f6c9a
Fix: work around remaining lack of HMR
airtonix 5973ff1
Fix: update snapshots
airtonix cd9d3bf
Fix: remove old snapshot
airtonix 198043b
Fix: add new snapshot
airtonix e761671
Fix: connect frontend HMR with devserver middleware
airtonix 61e7c97
Merge branch 'feature/104-replace-webpack-serve-with-webpack-dev-serv…
airtonix 024b084
Fix: remove HMR client injection. it's not required
airtonix 831a61f
Fix: use WDS provided HMR client bindings
airtonix cb3ad96
Fix: update snapshot
airtonix a3ba7d7
Fix: update snapshots using node 10
airtonix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,13 @@ const cli = meow(` | |
}, | ||
port: { | ||
type: 'string', | ||
alias: 'p' | ||
alias: 'p', | ||
default: '8080' | ||
}, | ||
host: { | ||
type: 'string', | ||
alias: 'h', | ||
default: '0.0.0.0' | ||
}, | ||
analyze: {}, | ||
// build | ||
|
@@ -145,8 +151,7 @@ switch (cmd) { | |
const dev = require('./lib/dev') | ||
dev(opts) | ||
.then(({ server }) => { | ||
const { port } = server.options | ||
const url = `http://localhost:${port}` | ||
const url = `http://${server.host}:${server.port}` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now we report the listening host interface |
||
log.stop( | ||
'dev server listening on', | ||
chalk.green(url), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,9 @@ | |
"x0": "cli.js" | ||
}, | ||
"scripts": { | ||
"start": "./cli.js docs", | ||
"build": "./cli.js build docs", | ||
"start": "node ./cli.js docs --debug", | ||
"debug": "node --nolazy --inspect-brk=5858 ./cli.js docs", | ||
"build": "node ./cli.js build docs", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. on windows 10, (powershell/cmd.exe) hashbangs have no effect. |
||
"test": "nyc ava --timeout=60s", | ||
"test:components": "nyc ava test/components.js", | ||
"cover": "nyc report --reporter=html --reporter=lcov" | ||
|
@@ -53,7 +54,6 @@ | |
"glamor": "^2.20.40", | ||
"gray-matter": "^4.0.1", | ||
"html-minifier": "^3.5.16", | ||
"koa-connect": "^2.0.1", | ||
"lodash.sortby": "^4.7.0", | ||
"meow": "^5.0.0", | ||
"mini-html-webpack-plugin": "^0.2.3", | ||
|
@@ -63,7 +63,7 @@ | |
"react": "^16.4.1", | ||
"react-dev-utils": "^5.0.1", | ||
"react-dom": "^16.4.1", | ||
"react-live": "^1.10.1", | ||
"react-live": "1.8.0-0", | ||
"react-router": "^4.3.1", | ||
"react-router-dom": "^4.3.1", | ||
"react-scope-provider": "^1.0.0-1", | ||
|
@@ -81,7 +81,7 @@ | |
"webpack": "^4.10.2", | ||
"webpack-bundle-analyzer": "^2.13.1", | ||
"webpack-merge": "^4.1.3", | ||
"webpack-serve": "^1.0.4" | ||
"webpack-dev-server": "3.1.9" | ||
}, | ||
"devDependencies": { | ||
"@compositor/logo": "^1.4.0", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed to supply these because i think
webpack-serve
was previously providing this default