-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Add unit tests for libc #1974
Draft
BWindey
wants to merge
13
commits into
c3lang:master
Choose a base branch
from
BWindey:libc-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+478
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alignments (style) in libc bindings
…after sort, and let everyone fail to compare results
Is this still a draft? |
Yes, I'm not ready yet with most functions. I'm a bit busy at the moment, but would like to get this out of draft status within at most 2 weeks, preferably 1 week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add unit tests for libc.
Along the way, I also discovered some issues with the bindings currently present. Some pointers being misaligned (
void *
instead ofvoid*
), but also a wrong return type forlibc::bsearch()
.This is a draft PR, because I'm far from done, but would like some input on how thorough these tests should be. I feel like they shouldn't be that thorough, because they should be battle-tested C-code, we're just testing that we can call them from C3, and potentially providing an example for people.