add condition over os_type to preproc #417
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good idea! Have you tested it already? :) |
|
I just tried it and it currently does not work. The fix is small but I want to improve a bit more stuff as I work with it. So I will keep it as a draft for now except if you want to have it merge early. |
FardaleM
force-pushed
the
cpp_os_type
branch
from
b45cb06
to
056889c
Compare
c-cube
force-pushed
the
main
branch
2 times, most recently
from
e4c484d
to
60bb2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on CCFilename, a lot of function depend on OS specific definition. Therefore I add the possibility to match the os_type using the preprocessor.