Initial migration to wasmtime_test
#8789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the initial migration to the `wasmtime_test` macro. This change starts by migrating all the applicable `func.rs` integration tests and at the same time it removes all the duplicated integration tests in `winch.rs`. Additionally, this change introduces a slight change to how the macro works. Inspired by bytecodealliance#8622 (review) it defaults to including all the known configuration combinations and allows the macro user to opt-out where applicable. This makes the usage of the macro less verbose. The intention is to follow-up with subsequent PRs to migrate the all the applicable tests.
This commit adds the ability to specify `wasm_features` when invoking the macro. If the feature is off by default, the macro will ensure that the feature is enabled in the resulting config. If the feature is not supported by any of the compiler strategies, no tests will be generated for such strategy.
|
Thanks for the review @alexcrichton. Your suggestions make sense to me, I've pushed an update in 9638a94. Let me know what you think. I also removed some redundant |
alexcrichton
approved these changes
Jun 13, 2024
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this pull request
Jun 13, 2024
Follow-up to: bytecodealliance#8789; fixes the validation error message.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
Follow-up to: #8789; fixes the validation error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the initial migration to the
wasmtime_testmacro.This change starts by migrating all the applicable
func.rsintegration tests and at the same time it removes all the duplicated integration tests inwinch.rs.Additionally, this change introduces a slight change to how the macro works. Inspired by #8622 (review) it defaults to including all the known configuration combinations and allows the macro user to opt-out where applicable. This makes the usage of the macro less verbose.
The intention is to follow-up with subsequent PRs to migrate the all the applicable tests.