cranelift: expand umbrella crate with more crates #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
May 16, 2024
cranelift/umbrella/Cargo.toml
Outdated
| @@ -12,10 +12,30 @@ keywords = ["compile", "compiler", "jit"] | |||
| edition.workspace = true | |||
|
|
|||
| [dependencies] | |||
| cranelift-codegen = { workspace = true } | |||
| cranelift-frontend = { workspace = true } | |||
| cranelift-codegen = { workspace = true, optional = true } | |||
There was a problem hiding this comment.
All other crates depend on cranelift-codegen, so I don't see any reason why you should be able to disable it.
There was a problem hiding this comment.
Makes sense! Updated!
tertsdiepraam
force-pushed
the
more-crates-in-umbrella
branch
from
9bec956
to
3d012e2
Compare
tertsdiepraam
force-pushed
the
more-crates-in-umbrella
branch
from
3d012e2
to
e2d69ef
Compare
github-actions
bot
added
the
cranelift
elliottt
approved these changes
May 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The publish step is failing because |
|
(@alexcrichton mentioned that the cycle could be broken by using a |
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 20, 2024
) * cranelift: expand umbrella crate with more crates * Break the dependency cycle between cranelift-jit and cranelift --------- Co-authored-by: Trevor Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7772
This adds the
interpreter,jit,module,native&objectcrates to the umbrella crate. All crates (including the existingcodegenandfrontendcrates) are feature gated. However,codegenandfrontendare default features, so backwards compatibility is retained if default features is not set to false. I wasn't quite sure which crates to include, but in my own project, I already depend onjit,moduleandnative. Based on their descriptions,interpreterandobjectalso seemed relevant as public API. I might have missed some other important crate.I figured this would be an easy fix, although I understand if the umbrella crate should not have all these crates. In that case, feel free to close this PR :)