Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a kubernetes environnement, when deploying the application following the documentation and while everything works fine in the cluster side, meaning that all pods are up, evrything works fine, etc...
i've added a parameter which should be an empty list to the constructor, this is used to make warnings or error messages unique in the pods logs, instead of having the same log line repeat itself infinitely, the problem i had in my case is that there are some ingresses that point to a port name instead of port number, and when _to_services function does not find a valid port number it logs the line as a "Ignoring unsupported ingress rule without backend service port number."
the test i've added check if the service name is already present on the list, otherwise it appends it and logs it for one time, because the next time it'll be present in the list ( this is obviously clear :) ).
We can discuss to provide you with other informations if needed.
Regards