Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make warnings unique #1603

Open
wants to merge 1 commit into
base: 1.5
Choose a base branch
from
Open

make warnings unique #1603

wants to merge 1 commit into from

Conversation

yacinebbt
Copy link

In a kubernetes environnement, when deploying the application following the documentation and while everything works fine in the cluster side, meaning that all pods are up, evrything works fine, etc...

i've added a parameter which should be an empty list to the constructor, this is used to make warnings or error messages unique in the pods logs, instead of having the same log line repeat itself infinitely, the problem i had in my case is that there are some ingresses that point to a port name instead of port number, and when _to_services function does not find a valid port number it logs the line as a "Ignoring unsupported ingress rule without backend service port number."
the test i've added check if the service name is already present on the list, otherwise it appends it and logs it for one time, because the next time it'll be present in the list ( this is obviously clear :) ).

We can discuss to provide you with other informations if needed.

Regards

@TheophileDiot
Copy link
Member

Hi @yacinebbt, nice finding for this. We'll review it and get back to you.

@TheophileDiot TheophileDiot self-requested a review October 22, 2024 10:01
@TheophileDiot TheophileDiot self-assigned this Oct 22, 2024
@TheophileDiot TheophileDiot added the enhancement New feature or request label Oct 22, 2024
@fl0ppy-d1sk fl0ppy-d1sk changed the base branch from master to 1.5 November 1, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants