component: prev/next navigation #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This component takes the list of resources of a collection, creates a flat array of all the resources to find the previous and next pages to display below a post.
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fbraure
approved these changes
Sep 3, 2024
| @@ -0,0 +1,14 @@ | |||
| <page-navigation> | |||
| <% if @previous.present? %> | |||
There was a problem hiding this comment.
Just asking... We don't need test on @previous.resource.relative_url and @previous.label presence ?
There was a problem hiding this comment.
resource is a Bridgetown class that always have a relative_url and label also always exist as a menu entry name.
Comment on lines
+10
to
+11
| pages = [] | ||
| get_resources(@entries, pages) |
There was a problem hiding this comment.
I would create a logic to set
Suggested change
| pages = [] | |
| get_resources(@entries, pages) | |
| pages = get_pages(@entries) |
fbraure
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component takes the list of resources of a collection, creates a flat array of all the resources to find the previous and next pages to display below a post.
It should be integrated in the upcoming OpenAPI guides and will look like this:
