Skip to content

Fix quotes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix quotes #1

wants to merge 1 commit into from

Conversation

hack3rvaillant
Copy link

@hack3rvaillant hack3rvaillant commented Mar 27, 2025

Switch from double quotes to single quotes in curl commands

Summary

This PR changes the quoting style in generated curl commands from double quotes to single quotes. This makes the generated commands more compatible with various shell environments and avoids common escaping issues when working with JSON payloads.

Changes

  • Changed all -d "..." parameters to use single quotes: -d '...'
  • Changed all -H "..." header parameters to use single quotes: -H '...'
  • Updated the escaping pattern in jsonContentToString() to handle single quotes instead of double quotes
  • Updated all test snapshots to reflect the new quoting style

Benefits

  • Improved compatibility with different shell environments
  • Easier to copy-paste commands that contain JSON with double quotes
  • More consistent with common curl usage patterns in documentation and examples

Testing

All existing tests pass with the updated snapshots.

@hack3rvaillant hack3rvaillant self-assigned this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant