Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention who made this thing #15

Merged
merged 1 commit into from
Apr 18, 2024
Merged

mention who made this thing #15

merged 1 commit into from
Apr 18, 2024

Conversation

philsturgeon
Copy link
Collaborator

@philsturgeon philsturgeon commented Mar 13, 2024

Lots of tooling vendors are excited for this handy example and want to use it, and I've been letting them know that's fine so long as they attribute it and follow license terms. This helps with attribution, as its already baked right in there.

Copy link
Collaborator

@paulRbr paulRbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phil. LGTM

@paulRbr
Copy link
Collaborator

paulRbr commented Apr 18, 2024

@philsturgeon shall we merge this one?

@Polo2
Copy link
Collaborator

Polo2 commented Apr 18, 2024

Hi both of you,
while mentioning Bump.sh in documentation, here come a suggestion in my mind (sorry in advance if it's not fully related to this PR 🙇 )

Why not going one step further, and link this API documentation to the excellent blog-post that introduce Travel API?

This could be done by adding a root externalDocs property?
WDYT?

@philsturgeon philsturgeon merged commit 596ce35 into main Apr 18, 2024
4 checks passed
@philsturgeon philsturgeon deleted the attribution branch April 18, 2024 11:25
@philsturgeon
Copy link
Collaborator Author

Great idea @Polo2, I'll work that in somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants