Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove libsvm from package's dependency. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
build/
dist/
pybrisque.egg-info
.DS_Store
21 changes: 19 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,30 @@ in the Spatial Domain"](https://ieeexplore.ieee.org/document/6272356/).


## Installation
LibSVM is required. On ubuntu or other debian-based system, you can install ```libsvm-dev``` package from apt as follows:

## Installing libsvm
LibSVM and its python bindings are required. Please ensure that the libsvm library and its python bindings are compatible with each other (even better, having the exact same version). On ubuntu or other debian-based system, you can install ```libsvm-dev``` package from apt as follows:

```apt-get install libsvm-dev```

As a note, libsvm version on debian package list is as follows:
- Ubuntu 16.04: 3.12
- Ubuntu 18.04: 3.21

If you're on debian, you can install its python binding with the exact same version by running:
```apt-get install python-libsvm```. Please be aware that the binding is only linked to Python 2.7. You can manually link them to your currently active environment by adding it to your PYTHONPATH or your sys path as such:
```
>> import sys
>>> sys.path.append('/usr/share/pyshared')
```


If you're using macOS, using brew, you can have the latest version (3.23). See [here](https://github.com/Homebrew/homebrew-core/blob/master/Formula/libsvm.rb).

## Installing pybrisque
The package is in PyPI so you can install it simply by this command:

```pip install --process-dependency-links pybrisque```
```pip install pybrisque```

## Usage
Initialize once:
Expand Down
3 changes: 1 addition & 2 deletions REQUIREMENTS.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
numpy
scipy
opencv-python-headless
-e git+https://github.com/Salinger/libsvm-python.git#egg=libsvm-python
opencv-python-headless
6 changes: 1 addition & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,7 @@
install_requires=[
'numpy',
'scipy',
'opencv-python',
'libsvm'
],
dependency_links=[
'git+https://github.com/akbargumbira/libsvm-python.git@master#egg=libsvm-0'
'opencv-python-headless'
],
classifiers=[
'Development Status :: 5 - Production/Stable',
Expand Down