New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#627 allow for the -I option in the Python interpreter wrapper #628
base: master
Are you sure you want to change the base?
Conversation
I am a bit uneasy with the fact that the option is accepted but silently swallowed. If ever anyone actually needs its normal effect, it will be hard to debug. Would there be a way to advertise the flag is accepted but swallowed that would support your VSCode use case ? |
I see your point. I don't have a very good answer, but: VSCode cannot really know it is not calling a "real" interpreter, so I see how it expects the
Perhaps we could warn the user when they start the python wrapper in "interactive" mode and did pass in Alternatively, we actually implement the "correct" There's a fair chance we will be playing catch up: as soon as VSCode sees a good reason to pass another option native to the "normal" Python interpreter, we're back at square one. |
I do agree that implementing the correct behaviour is overkill. Any chance to have VSCode provide some configuration to avoid the issue ? |
Unfortunately yup. |
I have no clear idea why https://github.com/buildout/buildout/actions/runs/4352805641/jobs/7670723752 is failing now. I can't really see a relation to my change. Anyone an idea of an approach to tackle this? |
I'll add a comment.
I don't see how to make that into a sensible request to the extension developer/maintainer. In a way, buildout is the odd one out here I'm afraid. |
src/zc/buildout/easy_install.py
Outdated
# The Python interpreter wrapper allows some of the options that a | ||
# "regular" Python interpreter accepts, but it only acts on the -i, -c | ||
# and -m options. The other option(s) are ignored. See | ||
# https://github.com/buildout/buildout/issues/627 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janwijbrand I used to refer to issues on websites, but they do eventually disappear. Would you mind explaining about VSCode need here ?
Current testing setup always uses last |
Done |
I see you did not add a test (which I am fine with). I guess you are also fine with the low risk that someone removes that 'useless' options. Is that right ? |
I did add not a new test indeed. I considered having had to update the existing test
|
See issue #627.